[Commits] r1944 - sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux

commits at geoext.org commits at geoext.org
Tue Mar 9 15:12:25 CET 2010


Author: fvanderbiest
Date: 2010-03-09 15:12:25 +0100 (Tue, 09 Mar 2010)
New Revision: 1944

Modified:
   sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/Measure.js
   sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/MeasurePosition.js
Log:
Measure ux: (a) unified scope var in MeasurePosition.js (b) removed OpenLayers.Function.bind in listeners with scope: this

Modified: sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/Measure.js
===================================================================
--- sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/Measure.js	2010-03-09 14:02:02 UTC (rev 1943)
+++ sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/Measure.js	2010-03-09 14:12:25 UTC (rev 1944)
@@ -88,9 +88,10 @@
      */
     buildControl: function(options) {
         var listeners = {
-            "measure": OpenLayers.Function.bind(this.display, this),
-            "deactivate": OpenLayers.Function.bind(this.cleanup, this),
-            "measurepartial": OpenLayers.Function.bind(this.cleanup, this)
+            "measure": this.display,
+            "deactivate": this.cleanup,
+            "measurepartial": this.cleanup,
+            scope: this
         };
         return new OpenLayers.Control.Measure(
             options.handler, Ext.apply({

Modified: sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/MeasurePosition.js
===================================================================
--- sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/MeasurePosition.js	2010-03-09 14:02:02 UTC (rev 1943)
+++ sandbox/fvanderbiest/geoext.ux/ux/Measure/lib/GeoExt.ux/MeasurePosition.js	2010-03-09 14:12:25 UTC (rev 1944)
@@ -31,6 +31,13 @@
      */
     constructor: function(config) {
         var scope = {
+            compiled: true,
+            isDegrees: function(units) {
+                if (units == 'degrees' || units == 'dd') {
+                    return true;
+                }
+                return false;
+            },
             decimals: (config.hasOwnProperty('decimals')) ? 
                 config.decimals : 2
         };
@@ -43,15 +50,6 @@
         arguments.callee.superclass.constructor.call(this, 
             OpenLayers.Handler.Point, config);
         
-        Ext.apply(scope, {
-            compiled: true,
-            isDegrees: function(units) {
-                if (units == 'degrees' || units == 'dd') {
-                    return true;
-                }
-                return false;
-            }
-        });
         this.template = new Ext.XTemplate(
             '<p>',
             '<tpl if="this.isDegrees(units)">lon</tpl>',



More information about the Commits mailing list